Re: [PATCH 2/5] aic94xx: plumb in I_T_nexus_reset task management function

James Bottomley
2008-02-24T06:01:30Z

On Sun, 2008-02-24 at 00:51 -0500, Jeff Garzik wrote:
> Tangent:
>
> Now that patches for ipr and sata_sx4 exist, libsas is the last holdout
> using libata's old error handling paths.
>
> I think Darrick was either scoping that work, or had preliminary patches?
>
> Anyway, that's holding back removal of a lot of libata code, so I wanted
> to make sure the issue remained in people's minds...

I've not really been following what the issue actually is, so hopefully
Darrick has.

At the moment, we don't use any of libata for error handling in libsas.
(In fact, there's a big issue with ATA error handling in libsas in
general, since the sequencer abort task doesn't know what to do with a
task that's at an ATA drive ... we need to detect that condition and
then apply the SATL abort function, which depends on whether we're NCQ
or not...SATA error handling was next on my list of things to look at).

James