From: Kay Sievers <kay.sievers@novell.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: kristen accardi <kaccardi@gmail.com>, scsi <linux-scsi@vger.kernel.org>
Subject: media change events for polled devices broken with current sdev_evt_send()
Date: Thu, 06 Mar 2008 10:29:22 +0100 [thread overview]
Message-ID: <1204795762.3136.27.camel@lov.site> (raw)
Hi Jeff,
a341cd0f (SCSI: add asynchronous event notification API)
introduces an event filter like:
+ if (!test_bit(evt->evt_type, sdev->supported_events)) {
+ kfree(evt);
+ return;
+ }
which breaks:
285e9670 (sr,sd: send media state change modification events)
Why are events sent through sdev_evt_send() filtered? In which case does
code send an event which we don't want to deliver?
Side note: introduced with a341cd0f is the sysfs file:
"evt_media_change", which has a store() method, but has the permission
0444. It should either have no store() method assigned, by introducing
something like DECLARE_EVT_RO(), or the file permission should be
changed to 0644.
Thanks,
Kay
next reply other threads:[~2008-03-06 9:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-06 9:29 Kay Sievers [this message]
2008-03-17 15:36 ` media change events for polled devices broken with current sdev_evt_send() Kay Sievers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1204795762.3136.27.camel@lov.site \
--to=kay.sievers@novell.com \
--cc=jeff@garzik.org \
--cc=kaccardi@gmail.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox