From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: nick.cheng@areca.com.tw
Cc: 'Andrew Morton' <akpm@linux-foundation.org>,
linux-scsi@vger.kernel.org, randy.dunlap@oracle.com,
'Tomas Henzl' <thenzl@redhat.com>,
viro@ftp.linux.org.uk
Subject: RE: [PATCH] modify the type of element of MessageUnit_B in arcmsr
Date: Thu, 06 Mar 2008 16:28:35 -0600 [thread overview]
Message-ID: <1204842515.3062.79.camel@localhost.localdomain> (raw)
In-Reply-To: <000601c87f2e$71731610$8800a8c0@Nick>
On Thu, 2008-03-06 at 10:04 +0800, nickcheng wrote:
> James,
> You are such a great teacher.
Heh, you know how to smooth talk
> I learned it.
> So what about my last submitted patch?
> Would it be turned down or go on?
I'm fine with either fix. For either we need a better changelog.
Something like:
The Type B Adapter teardown does iounmap on pointers subtracted by a
constant offset. Since the offset is in bytes, we need the pointers to
be of type void * not uint32_t * so the subtraction is done in the
correct units and we iounmap the correct area.
Signed-off-by: ...
James
prev parent reply other threads:[~2008-03-06 22:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-04 9:49 [PATCH] modify the type of element of MessageUnit_B in arcmsr nickcheng
2008-03-04 16:39 ` James Bottomley
2008-03-05 7:38 ` nickcheng
2008-03-05 15:30 ` James Bottomley
2008-03-06 2:04 ` nickcheng
2008-03-06 22:28 ` James Bottomley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1204842515.3062.79.camel@localhost.localdomain \
--to=james.bottomley@hansenpartnership.com \
--cc=akpm@linux-foundation.org \
--cc=linux-scsi@vger.kernel.org \
--cc=nick.cheng@areca.com.tw \
--cc=randy.dunlap@oracle.com \
--cc=thenzl@redhat.com \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox