From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Bottomley Subject: Re: [PATCH] isd200: Use scsi_get_cmnd for the extra translation command Date: Wed, 12 Mar 2008 12:00:09 -0500 Message-ID: <1205341209.2941.116.camel@localhost.localdomain> References: <47D7F397.4070903@panasas.com> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <47D7F397.4070903-C4P08NqkoRlBDgjK7y7TUQ@public.gmane.org> Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Boaz Harrosh Cc: Alan Stern , Matthew Dharm , linux-scsi , USB list , Andrew Morton List-Id: linux-scsi@vger.kernel.org On Wed, 2008-03-12 at 17:15 +0200, Boaz Harrosh wrote: > James > please comment on the use of DID_REQUEUE as return status for > the command in case of failure to allocate the extra command the first > time. I'm afraid it won't work. If you get a NULL return from scsi_get_command, it means that the command you already have was likely taken from the host free_list. If that command is in the memory clearing writeout path and we don't have any returning commands to replace the free_list, the system is now deadlocked. James -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html