From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Kay Sievers <kay.sievers@vrfy.org>
Cc: James.Smart@Emulex.Com, Greg KH <greg@kroah.com>,
linux-scsi@vger.kernel.org, Tony Jones <tonyj@suse.de>
Subject: Re: [patch] convert the scsi layer to use struct device
Date: Mon, 17 Mar 2008 08:55:50 -0500 [thread overview]
Message-ID: <1205762150.6767.120.camel@localhost.localdomain> (raw)
In-Reply-To: <1205761248.6338.13.camel@lov.site>
On Mon, 2008-03-17 at 14:40 +0100, Kay Sievers wrote:
> On Mon, 2008-03-17 at 08:18 -0400, James Smart wrote:
> > Greg KH wrote:
> > > I take it you haven't even looked at how !SYSFS_DEPRECATED works today,
> > > have you? Try it and you will see that the namespace issue has been
> > > taken care of a long time ago :)
> >
> > You are right... but I would assume it can be answered without pushing
> > someone back into the internals of the code to figure it out.
>
> Oh, I already answered it in an earlier mail :)
> "these links don't exist with !SYSFS_DEPRECATED, because the
> class devices live in subdirectories, named after the class
> they come from, there is no namespace problem"
>
> This is how a LUN looks now:
> tree /sys/devices/pci0000:00/0000:00:1d.7/usb5/5-1/5-1:1.0/host13/target13:0:0/13:0:0:0/
> /sys/devices/pci0000:00/0000:00:1d.7/usb5/5-1/5-1:1.0/host13/target13:0:0/13:0:0:0/
> |-- block
> | `-- sdb
> | |-- subsystem -> ../../../../../../../../../../../class/block
>
> | |-- sdb1
> | | |-- subsystem -> ../../../../../../../../../../../../class/block
>
> | |-- sdb2
> | | |-- subsystem -> ../../../../../../../../../../../../class/block
>
> |-- bsg
> | `-- 13:0:0:0
> | |-- subsystem -> ../../../../../../../../../../../class/bsg
>
> |-- scsi_disk
> | `-- 13:0:0:0
> | |-- subsystem -> ../../../../../../../../../../../class/scsi_disk
>
> |-- scsi_generic
> | `-- sg2
> | |-- subsystem -> ../../../../../../../../../../../class/scsi_generic
>
So the real answer is that the backlink <class>:<class device> becomes
the directory hierarchy <class>/<class device>.
The uniqueness is hopefully solved essentially because the <class> name
has to be unique. As long as there's no clash with the actual device
property names (not necessarily a given) we're fine.
I suppose it means we have to be a bit more careful about sysfs device
file names from now on.
James
next prev parent reply other threads:[~2008-03-17 13:55 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-13 21:06 [patch] convert the scsi layer to use struct device Greg KH
2008-03-14 14:13 ` Hannes Reinecke
2008-03-14 17:15 ` James Bottomley
2008-03-14 21:20 ` James Bottomley
2008-03-14 21:58 ` Kay Sievers
2008-03-15 14:19 ` James Bottomley
2008-03-15 15:17 ` Kay Sievers
2008-03-15 16:16 ` James Bottomley
2008-03-15 18:01 ` James Bottomley
2008-03-15 18:26 ` Kay Sievers
2008-03-15 18:34 ` James Bottomley
2008-03-15 20:38 ` Stefan Richter
2008-03-15 18:04 ` Kay Sievers
2008-03-15 18:31 ` James Bottomley
2008-03-15 18:56 ` Kay Sievers
2008-03-15 19:33 ` James Bottomley
2008-03-15 19:43 ` Kay Sievers
2008-03-16 20:21 ` James Smart
2008-03-16 21:04 ` Kay Sievers
2008-03-17 4:15 ` James Smart
2008-03-17 5:35 ` Greg KH
2008-03-17 12:18 ` James Smart
2008-03-17 13:40 ` Kay Sievers
2008-03-17 13:55 ` James Bottomley [this message]
2008-03-17 17:57 ` James Bottomley
2008-03-19 0:48 ` Greg KH
2008-03-19 20:38 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1205762150.6767.120.camel@localhost.localdomain \
--to=james.bottomley@hansenpartnership.com \
--cc=James.Smart@Emulex.Com \
--cc=greg@kroah.com \
--cc=kay.sievers@vrfy.org \
--cc=linux-scsi@vger.kernel.org \
--cc=tonyj@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox