From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Hannes Reinecke <hare@suse.de>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH 2/8] Fixup initialisation oops for anonymous transport classes
Date: Thu, 20 Mar 2008 13:14:40 -0500 [thread overview]
Message-ID: <1206036880.3038.32.camel@localhost.localdomain> (raw)
In-Reply-To: <20080318133228.53EAE1F60F@pentland.suse.de>
On Tue, 2008-03-18 at 14:32 +0100, Hannes Reinecke wrote:
> Anonymous transport classes might call transport_add_class_devices
> with NULL classdev.
They do ... but it doesn't cause an oops. class_device_add first calls
class_device_get() which returns -EINVAL for a NULL classdev. It looks
like device_add() does exactly the same thing in the new scheme, so what
oops were you seeing?
James
prev parent reply other threads:[~2008-03-20 18:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-18 13:32 [PATCH 2/8] Fixup initialisation oops for anonymous transport classes Hannes Reinecke
2008-03-20 18:14 ` James Bottomley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1206036880.3038.32.camel@localhost.localdomain \
--to=james.bottomley@hansenpartnership.com \
--cc=hare@suse.de \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox