From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Jeff Garzik <jeff@garzik.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Kay Sievers <kay.sievers@vrfy.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-scsi@vger.kernel.org
Subject: Re: [SCSI] fix media change events for polled devices
Date: Fri, 21 Mar 2008 14:38:37 -0500 [thread overview]
Message-ID: <1206128318.2961.32.camel@localhost.localdomain> (raw)
In-Reply-To: <alpine.LFD.1.00.0803211031010.3020@woody.linux-foundation.org>
On Fri, 2008-03-21 at 10:31 -0700, Linus Torvalds wrote:
>
> On Fri, 21 Mar 2008, Jeff Garzik wrote:
> >
> > And that is the fix -- initialize supported_events according to sr/sd's needs,
> > and revert this change (4d1566ed2100d074ccc654e5cf2e44cdea3a01d0) as obviously
> > broken.
>
> Patches, please? I can do the revert, but the patch to supported_events
> and the testing, please?
I tested this and discussed it with Kristen before it went in. The
current fix you sucked in with scsi-rc-fixes basically makes the whole
lot work for 2.6.25 (both AN media change events and traditional polled
ones). The thing that doesn't work is the ability to turn off AN events
from user space, but that feature never worked anyway.
I promised Kay I'd work on a better solution for 2.6.26 which will
include separating up the input events into polled and AN for a CD but
emitting the same media change event to udev at the top (so you can rely
on either polled or AN for media change and select which or both if you
desire).
James
next prev parent reply other threads:[~2008-03-21 19:38 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200803211559.m2LFxPi6017869@hera.kernel.org>
2008-03-21 17:12 ` [SCSI] fix media change events for polled devices Jeff Garzik
2008-03-21 17:31 ` Linus Torvalds
2008-03-21 19:38 ` James Bottomley [this message]
2008-03-21 20:54 ` Jeff Garzik
2008-03-21 20:39 ` Jeff Garzik
2008-03-21 18:33 ` Kay Sievers
2008-03-21 20:42 ` Jeff Garzik
2008-03-21 20:57 ` Kay Sievers
2008-03-21 21:04 ` James Bottomley
2008-03-21 21:10 ` Jeff Garzik
2008-03-21 19:44 ` James Bottomley
2008-03-21 20:36 ` Jeff Garzik
2008-03-21 21:01 ` James Bottomley
2008-03-21 21:04 ` Jeff Garzik
2008-03-21 21:09 ` James Bottomley
2008-03-21 21:13 ` Jeff Garzik
2008-03-21 21:49 ` James Bottomley
2008-03-21 22:35 ` Jeff Garzik
2008-03-21 22:52 ` James Bottomley
2008-03-25 3:09 ` Jeff Garzik
2008-03-25 3:18 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1206128318.2961.32.camel@localhost.localdomain \
--to=james.bottomley@hansenpartnership.com \
--cc=akpm@linux-foundation.org \
--cc=jeff@garzik.org \
--cc=kay.sievers@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox