From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Hannes Reinecke <hare@suse.de>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH 6/8] Fix spi initialisation failure
Date: Fri, 21 Mar 2008 16:15:06 -0500 [thread overview]
Message-ID: <1206134106.2961.55.camel@localhost.localdomain> (raw)
In-Reply-To: <20080318133228.6DFD9159159@pentland.suse.de>
On Tue, 2008-03-18 at 14:32 +0100, Hannes Reinecke wrote:
> With the target rework we cannot set the attribute of the
> sysfs files as the sysfs object is not registered yet. So
> just modify the attribute itself.
Actually, this isn't the problem. The problem is that the target is
added too early ... before we've had time to gather the necessary data
from the devices, so is_visible() is returning 0 (i.e. invisible) for a
lot of the files. Then when we try to chmod a nonexistent file, sysfs
goes boom.
I think this can be fixed by making the sysfs API more elastic ... I'll
send patches shortly.
James
prev parent reply other threads:[~2008-03-21 21:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-18 13:32 [PATCH 6/8] Fix spi initialisation failure Hannes Reinecke
2008-03-18 14:39 ` James Bottomley
[not found] ` <47DFE20A.7090503@suse.de>
2008-03-18 16:13 ` James Bottomley
2008-03-21 21:15 ` James Bottomley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1206134106.2961.55.camel@localhost.localdomain \
--to=james.bottomley@hansenpartnership.com \
--cc=hare@suse.de \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox