Re: [PATCH] mvsas: ATAPI LUN issue

James Bottomley
2008-03-27T23:20:43Z

On Tue, 2008-03-25 at 12:28 +0800, Ke Wei wrote:
> I found that sending REPORT_LUNS command to some DVD device will
> cause fis error and controller error record. As a result, scsi mid layer
> get some wrong LUNs. Also I can get some queer messages.
>
> scsi: host 12 channel 0 id 2 lun 0x30302e302f686f73 has a LUN larger
> than currently supported.
> scsi: host 12 channel 0 id 2 lun 0x7431322f706f7274 has a LUN larger
> than currently supported.
> scsi: host 12 channel 0 id 2 lun 0x2d31323a322f656e has a LUN larger
> than currently supported.
> ...
>
> The patch forced to clear the sg buffer of SATA response if FIS is
> error. But I suggest these codes should remove to the libsas module.

My first observation is that this isn't the correct approach: Most of
the CD/DVD simply respond with an error or the correct information. The
odd media changer will actually respond with real LUNs. Doing a blanket
erase of the REPORT LUN information will cause problems for media
changers.

I think the correct way to fix your problem is to blacklist the
particular CD. We have a BLIST_NOREPORTLUN for devices which behave
like this ... what are the INQUIRY strings?

James