From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Grant Grundler <grundler@google.com>,
akpm@linux-foundation.org, linux-scsi@vger.kernel.org,
fujita.tomonori@lab.ntt.co.jp
Subject: Re: [patch 13/17] drivers/scsi/initio.c: suppress compile warning
Date: Fri, 28 Mar 2008 18:51:53 -0500 [thread overview]
Message-ID: <1206748313.3662.66.camel@localhost.localdomain> (raw)
In-Reply-To: <20080328224335.1f14cf6a@core>
On Fri, 2008-03-28 at 22:43 +0000, Alan Cox wrote:
> > Alan, has this driver ever worked on a BE platform?
>
> Not afaik.
It looks to me like the SCSI piece is entirely driven by the state model
in tulip_scsi, which seems to drive the phases by I/O instructions which
are endian safe, so the only issue I can see is the actual SG entries
themselves, which begin as an outl of the pointer to the SG table, but
which must be pulled into the card by DMA.
So basically, most of the cpu_to_le32 in this driver look wrong. If I
can fix it (or persuade someone else to fix it) can anyone test it on a
BE platform?
James
next prev parent reply other threads:[~2008-03-28 23:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-28 21:48 [patch 13/17] drivers/scsi/initio.c: suppress compile warning akpm
2008-03-28 21:55 ` Grant Grundler
2008-03-28 22:13 ` Andrew Morton
2008-03-28 22:26 ` James Bottomley
2008-03-28 22:43 ` Alan Cox
2008-03-28 23:51 ` James Bottomley [this message]
2008-03-29 0:49 ` Grant Grundler
2008-03-29 3:09 ` James Bottomley
2008-03-31 4:50 ` Grant Grundler
2008-03-31 14:56 ` James Bottomley
2008-03-31 16:23 ` Grant Grundler
2008-04-04 7:05 ` Grant Grundler
2008-04-05 16:14 ` Grant Grundler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1206748313.3662.66.camel@localhost.localdomain \
--to=james.bottomley@hansenpartnership.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=grundler@google.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox