From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: kewei@marvell.com
Cc: linux-scsi@vger.kernel.org, jeff@garzik.org
Subject: Re: [PATCH 3/9][RESEND] mvsas : interrupt handling
Date: Sun, 30 Mar 2008 10:09:57 -0500 [thread overview]
Message-ID: <1206889797.4224.20.camel@localhost.localdomain> (raw)
In-Reply-To: <47EB449F.20201@marvell.com>
On Thu, 2008-03-27 at 14:54 +0800, Ke Wei wrote:
> When a slot is busy, we will not free this slot until slot reset is completed.
> When unplugged the disk, we should release all command tasks with unplugged port that have been sent.
> If MVS_USE_TASKLET is defined, we can enable tasklet. Default is off.
This tasklet usage doesn't quite look right. What a tasklet does is
defer processing until after all interrupts have completed. It's
commonly used for aggregation, which is why scsi_done simply queues for
the block softirq (tasklet). However, for mvsas, I don't see any
benefit to defering the work to a tasklet.
Additionally, for the non MSI case, doesn't the interrupt, which is
level triggered, fail to deassert because we haven't cleared any
registers?
James
next prev parent reply other threads:[~2008-03-30 15:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-27 6:54 [PATCH 3/9][RESEND] mvsas : interrupt handling Ke Wei
2008-03-30 15:09 ` James Bottomley [this message]
2008-03-31 10:23 ` Ke Wei
2008-03-31 14:46 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1206889797.4224.20.camel@localhost.localdomain \
--to=james.bottomley@hansenpartnership.com \
--cc=jeff@garzik.org \
--cc=kewei@marvell.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox