Re: [patch 08/17] scsi: replace remaining __FUNCTION__ occurrences

Andrew Morton
2008-03-28T22:45:23Z

On Fri, 28 Mar 2008 17:35:04 -0500
James Bottomley <James.Bottomley@HansenPartnership.com> wrote:

> On Fri, 2008-03-28 at 14:48 -0700, akpm@linux-foundation.org wrote:
> > From: Harvey Harrison <harvey.harrison@gmail.com>
> >
> > __FUNCTION__ is gcc-specific, use __func__
>
> I thought we basically agreed

No.

> there was no point to this since if it
> ever became an issue you can do
>
> #define __FUNCTION__ __func__
>
> inside the include/compiler-xxx.h file
>

It's better to get things right at the original code site, rather than
adding crufty back-compatibility macros.

The patches are easy to prepare, easy to review and easy to merge. There's
no reason to not do so.