From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: akpm@linux-foundation.org
Cc: linux-scsi@vger.kernel.org, Mark_Salyzyn@adaptec.com,
aacraid@adaptec.com, fujita.tomonori@lab.ntt.co.jp,
jeff@garzik.org
Subject: Re: [patch 12/17] ips.c: fix build warning
Date: Sun, 30 Mar 2008 12:07:22 -0500 [thread overview]
Message-ID: <1206896842.4224.46.camel@localhost.localdomain> (raw)
In-Reply-To: <200803282148.m2SLmeDg012249@imap1.linux-foundation.org>
On Fri, 2008-03-28 at 14:48 -0700, akpm@linux-foundation.org wrote:
> From: Andrew Morton <akpm@linux-foundation.org>
>
> powerpc:
>
> drivers/scsi/ips.c: In function 'ips_issue_copperhead':
> drivers/scsi/ips.c:5436: warning: large integer implicitly truncated to unsigned type
>
> it doesn't seem necessary to do outw(cpu_to_le32(...), ...) anyway.
Actually, it's not only not necessary ... it's an actual bug on BE
platforms. Both writeX and outX/inX automatically convert from native
to bus endian (usually simply to LE since the bus is PCI). Therefore if
you add a cpu_to_leX, you actually write the wrong value on a BE system.
Mark, it looks like the correct fix is simply to strip all of these ...
has this driver actually been tested on a BE platform (like parisc or
PPC)?
James
next prev parent reply other threads:[~2008-03-30 17:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-28 21:48 [patch 12/17] ips.c: fix build warning akpm
2008-03-30 17:07 ` James Bottomley [this message]
2008-03-30 23:57 ` FUJITA Tomonori
2008-04-03 17:28 ` James Bottomley
2008-04-04 18:38 ` Mark Salyzyn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1206896842.4224.46.camel@localhost.localdomain \
--to=james.bottomley@hansenpartnership.com \
--cc=Mark_Salyzyn@adaptec.com \
--cc=aacraid@adaptec.com \
--cc=akpm@linux-foundation.org \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=jeff@garzik.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox