From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kay Sievers Subject: Re: [PATCH 1/2] sysfs: allow the group is_visible() method to return a mode and add an update API Date: Mon, 31 Mar 2008 15:42:09 +0200 Message-ID: <1206970929.20492.27.camel@lov.site> References: <1206134832.2961.64.camel@localhost.localdomain> <20080321222635.GA2674@kroah.com> <1206208949.4393.25.camel@localhost.localdomain> <1206896083.4224.40.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from charybdis-ext.suse.de ([195.135.221.2]:53553 "EHLO emea5-mh.id5.novell.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750863AbYCaNhW (ORCPT ); Mon, 31 Mar 2008 09:37:22 -0400 In-Reply-To: <1206896083.4224.40.camel@localhost.localdomain> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: James Bottomley Cc: Greg KH , Hannes Reinecke , linux-scsi , linux-kernel On Sun, 2008-03-30 at 11:54 -0500, James Bottomley wrote: > On Sat, 2008-03-22 at 13:02 -0500, James Bottomley wrote: > > On Fri, 2008-03-21 at 15:26 -0700, Greg KH wrote: > > > On Fri, Mar 21, 2008 at 04:27:12PM -0500, James Bottomley wrote: > > > > We have a problem in scsi_transport_spi in that we need to cust= omise > > > > not only the visibility of the attributes, but also their mode.= Fix > > > > this by making the is_visible() callback return a mode, with 0 > > > > indicating is not visible. > > > >=20 > > > > Also add a sysfs_update_group() API to allow us to change eithe= r the > > > > visibility or mode of the files at any time on the fly. > > > >=20 > > > > Signed-off-by: James Bottomley > > > > --- > > > >=20 > > > > Greg, can I take this through SCSI, please ... assuming it's OK= ? We > > > > need this to fix up the SPI transport class. > > >=20 > > > Sure. But can you document that "update" field a bit more so we = can > > > remember what it means in the future? > >=20 > > How about this? I also added docbook for create and update attribu= te > > group. Looks good to me. I think with the "visible" stuff for attribute groups, will be able to fix the USB event timing problem, by moving the creation of the device attributes to default attributes. So I'm looking forward to have this i= n the tree. > Can I get an ACK from someone from sysfs for this, please? > > --- > >=20 > > From: James Bottomley > > Date: Thu, 20 Mar 2008 20:47:52 -0500 > > Subject: [SCSI] sysfs: make group is_valid return a mode_t > >=20 > > We have a problem in scsi_transport_spi in that we need to customis= e > > not only the visibility of the attributes, but also their mode. Fi= x > > this by making the is_visible() callback return a mode, with 0 > > indicating is not visible. > >=20 > > Also add a sysfs_update_group() API to allow us to change either th= e > > visibility or mode of the files at any time on the fly. Acked-by: Kay Sievers > > Signed-off-by: James Bottomley =EF=BB=BFThanks for doing this, Kay -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html