From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Mark Salyzyn <Mark_Salyzyn@adaptec.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
"alan@lxorguk.ukuu.org.uk" <alan@lxorguk.ukuu.org.uk>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: + aacraid-fix-unchecked-down_interruptible.patch added to -mm tree
Date: Thu, 10 Apr 2008 16:57:37 -0500 [thread overview]
Message-ID: <1207864657.4915.40.camel@localhost.localdomain> (raw)
In-Reply-To: <69D7FE1A-36E3-4BA4-8B54-728B50E7E6B7@adaptec.com>
On Thu, 2008-04-10 at 17:44 -0400, Mark Salyzyn wrote:
> if (down_interruptible(&fibptr->event_wait) == 0) {
> fibptr->done = 2;
> up(&fibptr->event_wait);
> }
>
> would make me feel much more comfortable ... The fib can never be
> 'freed'. The fib is owned by the adapter until it completes it on it's
> own (if ever, the assumption here is that the adapter is misbehaving
> on this 'one' fib). Setting the value of 2 allows us to report back to
> the ioctl caller a failed operation without actually closing out the
> fib.
>
> I am having a problem with my bandwidth right now to do a unit test to
> see if this gets the job done.
That's OK ... send the patch when you're ready; I'll make sure it gets
upstream. We'll do the standard put it into scsi-misc and backport if
it seems stable, so we'll have time to shake out any problems.
James
next prev parent reply other threads:[~2008-04-10 21:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200804102037.m3AKb2g4016314@imap1.linux-foundation.org>
2008-04-10 20:54 ` + aacraid-fix-unchecked-down_interruptible.patch added to -mm tree James Bottomley
2008-04-10 21:19 ` Mark Salyzyn
2008-04-10 21:29 ` Andrew Morton
2008-04-10 21:44 ` Mark Salyzyn
2008-04-10 21:57 ` James Bottomley [this message]
2008-04-14 18:20 ` Mark Salyzyn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1207864657.4915.40.camel@localhost.localdomain \
--to=james.bottomley@hansenpartnership.com \
--cc=Mark_Salyzyn@adaptec.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox