From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Miquel van Smoorenburg <miquels@cistron.nl>
Cc: Linux-Scsi <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH 1/2] dpt_i2o: 64 bit support (take 3)
Date: Thu, 24 Apr 2008 10:39:53 -0500 [thread overview]
Message-ID: <1209051593.3121.10.camel@localhost.localdomain> (raw)
In-Reply-To: <20080424150717.GA21438@xs4all.net>
Just gave it a cursory glance, and it looks OK, except for things like
this:
On Thu, 2008-04-24 at 17:07 +0200, Miquel van Smoorenburg wrote:
> +#elif defined(__linux__)
Could you get rid it, please? For inclusion in the kernel, you can take
it as read that we're operating in a Linux environment, so the symbol
will always be defined (so you can just strip out the code that depends
on this symbol not being defined).
Thanks,
James
next prev parent reply other threads:[~2008-04-24 15:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-24 15:07 [PATCH 1/2] dpt_i2o: 64 bit support (take 3) Miquel van Smoorenburg
2008-04-24 15:39 ` James Bottomley [this message]
2008-04-24 20:24 ` Miquel van Smoorenburg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1209051593.3121.10.camel@localhost.localdomain \
--to=james.bottomley@hansenpartnership.com \
--cc=linux-scsi@vger.kernel.org \
--cc=miquels@cistron.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox