Re: [PATCH 4/5] aic7xxx: teach aicasm to not emit unused debug code/data

[James Bottomley <James.Bottomley@HansenPartnership.com>]

On Fri, 2008-04-25 at 15:01 +0200, Hannes Reinecke wrote:
> Hi Denys,
> 
> Denys Vlasenko wrote:
> > Add "dont_generate_debug_code" syntax handling to aicasm_gram.y
> > 
> > aic79xx.reg, aic7xxx.reg: add dont_generate_debug_code keyword
> > for registers which are never referenced by the driver.
> > 
> > aicasm.c, aicasm_symbol.[ch]: don't emit code for those regs;
> > also add "const" keyword to generated code in few places.
> > 
> > Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
> No.
> Adding a symbol to each and every register definition
> which has to be hand-crafted anyway is not the correct way.
> 
> I would prefer this: Add a 'count' variable to each symbol
> which gets increased every time the symbol is referenced.
> And then modify the register definition to include counts
> for symbols which are referenced from the source code only
> and not from the sequencer code.
> 
> This will give us an automatic usage count for the symbols
> with only minimal hand-crafting.
> 
> James, please apply.

Well .. I have done, but you can take a black mark for this ... there's
no Signed-off-by line.

James