From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Walker <dwalker@mvista.com>
Subject: Re: [PATCH] qla2xxx: firmware semaphore to mutex
Date: Mon, 28 Apr 2008 12:21:58 -0700
Message-ID: <1209410518.12461.71.camel@localhost.localdomain>
References: <20080428174742.163523860@mvista.com>
	 <20080428180846.GX14990@parisc-linux.org>
	 <1209409033.12461.64.camel@localhost.localdomain>
	 <20080428190425.GY14990@parisc-linux.org>
Mime-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Return-path: <linux-scsi-owner@vger.kernel.org>
Received: from gateway-1237.mvista.com ([63.81.120.158]:40213 "EHLO
	gateway-1237.mvista.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S934545AbYD1TWA (ORCPT
	<rfc822;linux-scsi@vger.kernel.org>); Mon, 28 Apr 2008 15:22:00 -0400
In-Reply-To: <20080428190425.GY14990@parisc-linux.org>
Sender: linux-scsi-owner@vger.kernel.org
List-Id: linux-scsi@vger.kernel.org
To: Matthew Wilcox <matthew@wil.cx>
Cc: James.Bottomley@HansenPartnership.com, mingo@elte.hu, linux-driver@qlogic.com, linux-scsi@vger.kernel.org, akpm@linux-foundation.org


On Mon, 2008-04-28 at 13:04 -0600, Matthew Wilcox wrote:
> it returns -EINTR and it's
> up to the caller to handle it and unwind back to userspace.  ie it's
> halfway between mutex_lock_interruptible() (any signal) and
> mutex_lock()
> (no signal).


In the hunk you quoted (below),

> > -       down(&qla_fw_lock);
> > +       if (mutex_lock_killable(&qla_fw_lock))
> > +               return NULL;

Don't you need to return the -EINTR so the caller knows the nature of
the failure? You might also need to re-factor the caller of this
function so it properly reports the failure to userspace .. In this case
your just returning NULL .. 

(CC'd Andrew since I think this was something he was concerned about,
with mutex_lock_interruptible().)

Daniel