From: Daniel Walker <dwalker@mvista.com>
To: Matthew Wilcox <matthew@wil.cx>
Cc: James.Bottomley@HansenPartnership.com, mingo@elte.hu,
linux-driver@qlogic.com, linux-scsi@vger.kernel.org,
akpm@linux-foundation.org
Subject: Re: [PATCH] qla2xxx: firmware semaphore to mutex
Date: Mon, 28 Apr 2008 12:54:58 -0700 [thread overview]
Message-ID: <1209412498.12461.78.camel@localhost.localdomain> (raw)
In-Reply-To: <20080428192416.GZ14990@parisc-linux.org>
On Mon, 2008-04-28 at 13:24 -0600, Matthew Wilcox wrote:
> On Mon, Apr 28, 2008 at 12:21:58PM -0700, Daniel Walker wrote:
> > Don't you need to return the -EINTR so the caller knows the nature of
> > the failure? You might also need to re-factor the caller of this
> > function so it properly reports the failure to userspace .. In this case
> > your just returning NULL ..
>
> The signal is _fatal_. Userspace doesn't get to check the return value.
> It's dead.
Kernel space does still observe the failure, right? Otherwise you
wouldn't return anything from mutex_lock_killable() .. If that's the
case just returning NULL , is like just injecting a failure.. I'm not
against adding mutex_lock_killable() , I'm just wondering if your
changes are complete in this case..
Daniel
next prev parent reply other threads:[~2008-04-28 19:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-28 17:47 [PATCH] qla2xxx: firmware semaphore to mutex Daniel Walker
2008-04-28 18:08 ` Matthew Wilcox
2008-04-28 18:57 ` Daniel Walker
2008-04-28 19:04 ` Matthew Wilcox
2008-04-28 19:21 ` Daniel Walker
2008-04-28 19:24 ` Matthew Wilcox
2008-04-28 19:33 ` Ingo Molnar
2008-04-28 19:54 ` Daniel Walker [this message]
2008-04-28 20:55 ` Andrew Vasquez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1209412498.12461.78.camel@localhost.localdomain \
--to=dwalker@mvista.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=akpm@linux-foundation.org \
--cc=linux-driver@qlogic.com \
--cc=linux-scsi@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox