From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Brian King <brking@linux.vnet.ibm.com>
Cc: linux-scsi@vger.kernel.org, thlin@linux.vnet.ibm.com,
wayneb@linux.vnet.ibm.com, pbadari@linux.vnet.ibm.com
Subject: Re: [PATCH 1/1] ipr: Rename ipr's state scsi host attribute to prevent collisions
Date: Mon, 28 Apr 2008 18:50:32 -0400 [thread overview]
Message-ID: <1209423032.3367.76.camel@localhost.localdomain> (raw)
In-Reply-To: <12094221802009-patch-mail.ibm.com>
On Mon, 2008-04-28 at 17:36 -0500, Brian King wrote:
> Due to recent SCSI core changes which add a scsi host attribute
> named "state", this now collides with an ipr driver scsi host attribute
> with the same name, preventing ipr from loading. Rename the ipr driver
> attribute to be more specific.
Heh, since the mid-layer state variable was introduced in March 2004 and
then ipr added the one that overwrote it in November 2005, that's an
interesting revision of history.
The actual problem is that recent changes to the device model by Greg
and Kay mean that it no longer silently tolerates this type of attribute
overwriting.
James
next prev parent reply other threads:[~2008-04-28 22:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <12094221802009-patch-mail.ibm.com>
2008-04-28 22:47 ` [PATCH 1/1] ipr: Rename ipr's state scsi host attribute to prevent collisions Badari Pulavarty
2008-04-28 22:50 ` James Bottomley [this message]
2008-05-02 15:49 ` 2.6.25-git18 ipr panic (was [PATCH 1/1] ipr: Rename ipr's state scsi host attribute to prevent collisions) Badari Pulavarty
2008-04-28 22:36 [PATCH 1/1] ipr: Rename ipr's state scsi host attribute to prevent collisions Brian King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1209423032.3367.76.camel@localhost.localdomain \
--to=james.bottomley@hansenpartnership.com \
--cc=brking@linux.vnet.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=pbadari@linux.vnet.ibm.com \
--cc=thlin@linux.vnet.ibm.com \
--cc=wayneb@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox