* [PATCH 2/9] scsi: use the common hex_asc array rather than a private one
@ 2008-05-01 23:05 Harvey Harrison
0 siblings, 0 replies; only message in thread
From: Harvey Harrison @ 2008-05-01 23:05 UTC (permalink / raw)
To: Andrew Morton; +Cc: James Bottomley, LKML, linux-scsi
Also use the hi/lo helpers.
Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
---
drivers/scsi/ibmmca.c | 3 +--
drivers/scsi/ultrastor.c | 4 ++--
2 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/scsi/ibmmca.c b/drivers/scsi/ibmmca.c
index 4d15a62..6765a05 100644
--- a/drivers/scsi/ibmmca.c
+++ b/drivers/scsi/ibmmca.c
@@ -1002,12 +1002,11 @@ static char *ti_p(int dev)
/* interpreter for logical device numbers (ldn) */
static char *ti_l(int val)
{
- const char hex[16] = "0123456789abcdef";
static char answer[2];
answer[1] = (char) (0x0);
if (val <= MAX_LOG_DEV)
- answer[0] = hex[val];
+ answer[0] = hex_asc[val];
else
answer[0] = '-';
return (char *) &answer;
diff --git a/drivers/scsi/ultrastor.c b/drivers/scsi/ultrastor.c
index 27aa40f..25828ce 100644
--- a/drivers/scsi/ultrastor.c
+++ b/drivers/scsi/ultrastor.c
@@ -876,8 +876,8 @@ static int ultrastor_abort(struct scsi_cmnd *SCpnt)
for (i = 0; i < 16; i++)
{
unsigned char p = inb(port0 + i);
- out[28 + i * 3] = "0123456789abcdef"[p >> 4];
- out[29 + i * 3] = "0123456789abcdef"[p & 15];
+ out[28 + i * 3] = hex_asc_hi(p);
+ out[29 + i * 3] = hex_asc_lo(p);
out[30 + i * 3] = ' ';
}
out[28 + i * 3] = '\n';
--
1.5.5.1.305.g7c84
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2008-05-01 23:05 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-05-01 23:05 [PATCH 2/9] scsi: use the common hex_asc array rather than a private one Harvey Harrison
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).