linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: bugme-daemon@bugzilla.kernel.org
Cc: linux-scsi@vger.kernel.org, Greg KH <greg@kroah.com>,
	Kay Sievers <kay.sievers@vrfy.org>
Subject: Re: [Bug 9872] Driver 'sd' needs updating - please use bus_type methods
Date: Sun, 04 May 2008 09:34:21 -0500	[thread overview]
Message-ID: <1209911661.16283.16.camel@localhost.localdomain> (raw)
In-Reply-To: <20080504002244.D924910805F@picon.linux-foundation.org>

On Sat, 2008-05-03 at 17:22 -0700, bugme-daemon@bugzilla.kernel.org
wrote:
> http://bugzilla.kernel.org/show_bug.cgi?id=9872

This isn't a bug.  There have been numerous discussions about fixing it.

The warning comes out of here in drivers/base/driver.c:

	if ((drv->bus->probe && drv->probe) ||
	    (drv->bus->remove && drv->remove) ||
	    (drv->bus->shutdown && drv->shutdown))
		printk(KERN_WARNING "Driver '%s' needs updating - please use "
			"bus_type methods\n", drv->name);

The problem is that SCSI drivers have both: SCSI uses the bus methods to
trigger the probe and remove (as it must having a bus method) but it
also uses the individual struct driver probe and remove methods to
rethrow the events to the ULDs.

According to Kay and Greg, this is a legitimate way of operating, and
they're not going to remove the driver methods (otherwise we'd just take
them into struct scsi_driver), so we're stuck trying to find a way to
prevent the base warning about this.

James



  reply	other threads:[~2008-05-04 14:34 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-9872-11613@http.bugzilla.kernel.org/>
2008-02-07 19:54 ` [Bug 9872] Driver 'sd' needs updating - please use bus_type methods bugme-daemon
2008-05-04  0:22 ` bugme-daemon
2008-05-04 14:34   ` James Bottomley [this message]
2008-05-05 16:22     ` Kay Sievers
2008-05-04 14:34 ` bugme-daemon
2008-05-05 16:24 ` bugme-daemon
2008-06-02  6:46 ` bugme-daemon
2008-06-05 23:52 ` bugme-daemon
2009-03-24 11:21 ` bugme-daemon
2009-03-24 11:24 ` bugme-daemon
2009-03-24 11:24 ` bugme-daemon
2009-07-18 12:34 ` bugzilla-daemon
2010-01-19 20:17 ` bugzilla-daemon
     [not found] <bug-9872-11613@https.bugzilla.kernel.org/>
2012-05-17 15:31 ` bugzilla-daemon
2012-05-17 15:31 ` bugzilla-daemon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1209911661.16283.16.camel@localhost.localdomain \
    --to=james.bottomley@hansenpartnership.com \
    --cc=bugme-daemon@bugzilla.kernel.org \
    --cc=greg@kroah.com \
    --cc=kay.sievers@vrfy.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).