Re: [PATCH] Stop using num_physpages in aacraid

[James Bottomley <James.Bottomley@HansenPartnership.com>]

On Fri, 2008-05-09 at 02:39 -0400, Mark Salyzyn wrote:
> ACK
> 
> with comment, I had chosen to perform the sizeof check as it optimized  
> out the code on the 32 bit platforms and could have merged the  
> aac_scsi_32_64 and aac_scsi_32 functions (such considerations are my  
> penance for writing peephole optimizers and BIOS code in C/C++). Never  
> sacrifice clarity/maintainability for optimization if you can afford it.

Yes ... I wish there were some way of getting the 

dma_get_required_mask() > DMA_32BIT_MASK

to compile out in the 32 bit case.  I'll think about it.


Another thing to note is that your problem could be solved if we could
adjust the queue mask per device (you want a 64 bit mask for the raid
devices and a 32 bit one for the physical ones).  This is analagous to
the ATA MDMA problem with ATA/ATAPI (the protocol can only do 32 bits
with ATAPI but the full 64 bits with ATA).  I'll see if we can use this
as a case to drive a fix for that.

James