From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Frank de Jong <frapex@xs4all.nl>
Cc: linux-scsi@vger.kernel.org, Juergen Fischer <fischer@norbit.de>
Subject: Re: PROBLEM: linux-2.6.25.3, aha152x'->init suspiciously returned 1, it should follow 0/-E convention
Date: Sat, 10 May 2008 08:33:58 -0500 [thread overview]
Message-ID: <1210426438.4002.1.camel@localhost.localdomain> (raw)
In-Reply-To: <20080510103040.C7E891D652BF@mx.drokz.nl>
On Sat, 2008-05-10 at 12:30 +0200, Frank de Jong wrote:
> Hello,
>
> Bug report follows.
>
> [1.] One line summary of the problem:
> linux-2.6.25.3, aha152x'->init suspiciously returned 1, it should
> follow 0/-E convention. The module / driver works okay. Unloading the
> module is impossible.
The driver is apparently returning 0 on failure and 1 on success.
That's a bit unfortunate. This should fix it.
James
---
diff --git a/drivers/scsi/aha152x.c b/drivers/scsi/aha152x.c
index f5215fd..f0c4ffc 100644
--- a/drivers/scsi/aha152x.c
+++ b/drivers/scsi/aha152x.c
@@ -3830,7 +3830,7 @@ static int __init aha152x_init(void)
iounmap(p);
}
if (!ok && setup_count == 0)
- return 0;
+ return -ENODEV;
printk(KERN_INFO "aha152x: BIOS test: passed, ");
#else
@@ -3909,7 +3909,7 @@ static int __init aha152x_init(void)
#endif
}
- return 1;
+ return 0;
}
static void __exit aha152x_exit(void)
next prev parent reply other threads:[~2008-05-10 13:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-10 10:30 PROBLEM: linux-2.6.25.3, aha152x'->init suspiciously returned 1, it should follow 0/-E convention Frank de Jong
2008-05-10 13:33 ` James Bottomley [this message]
2008-05-10 17:54 ` Frank de Jong
2008-05-10 19:08 ` James Bottomley
2008-05-10 20:28 ` Frank de Jong
[not found] ` <7.1.0.9.2.20080510194439.025745e0@xs4all.nl>
2008-05-10 17:58 ` Frank de Jong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1210426438.4002.1.camel@localhost.localdomain \
--to=james.bottomley@hansenpartnership.com \
--cc=fischer@norbit.de \
--cc=frapex@xs4all.nl \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox