From: Chandra Seetharaman <sekharan@us.ibm.com>
To: Hannes Reinecke <hare@suse.de>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>,
linux-scsi@vger.kernel.org, dm-devel <dm-devel@redhat.com>
Subject: Re: [PATCH 4/7] scsi_dh: Update EMC handler
Date: Wed, 14 May 2008 19:47:09 -0700 [thread overview]
Message-ID: <1210819629.21974.255.camel@chandra-ubuntu> (raw)
In-Reply-To: <20080514144324.3000410B5DF@craiglockhart-ipmi.suse.de>
On Wed, 2008-05-14 at 16:43 +0200, Hannes Reinecke wrote:
<snip>
>
> @@ -438,10 +604,32 @@ static int clariion_bus_attach(struct scsi_device *sdev)
> sdev->scsi_dh_data = scsi_dh_data;
> spin_unlock_irqrestore(sdev->request_queue->queue_lock, flags);
>
Can move the block above to be just before try_module_get() and avoid
undoing it in the failed path.
> - sdev_printk(KERN_NOTICE, sdev, "Attached %s.\n", CLARIION_NAME);
> + err = clariion_std_inquiry(sdev);
> + if (err != SCSI_DH_OK)
> + goto failed;
> +
> + err = clariion_send_inquiry(sdev);
> + if (err != SCSI_DH_OK)
> + goto failed;
> +
next prev parent reply other threads:[~2008-05-15 2:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-14 14:43 [PATCH 4/7] scsi_dh: Update EMC handler Hannes Reinecke
2008-05-15 2:47 ` Chandra Seetharaman [this message]
2008-05-15 8:09 ` Hannes Reinecke
2008-05-16 18:38 ` Chandra Seetharaman
-- strict thread matches above, loose matches on Subject: below --
2008-05-20 14:05 Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1210819629.21974.255.camel@chandra-ubuntu \
--to=sekharan@us.ibm.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=dm-devel@redhat.com \
--cc=hare@suse.de \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox