From: Chandra Seetharaman <sekharan@us.ibm.com>
To: Hannes Reinecke <hare@suse.de>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH 5/7] scsi_dh: Update hp_sw hardware handler
Date: Wed, 14 May 2008 19:47:54 -0700 [thread overview]
Message-ID: <1210819674.21974.258.camel@chandra-ubuntu> (raw)
In-Reply-To: <20080514144328.55FD010B5DF@craiglockhart-ipmi.suse.de>
No need for blk_put_request() as noted in an earlier patch.
On Wed, 2008-05-14 at 16:43 +0200, Hannes Reinecke wrote:
<snip>
> spin_lock_irqsave(sdev->request_queue->queue_lock, flags);
> sdev->scsi_dh_data = scsi_dh_data;
> spin_unlock_irqrestore(sdev->request_queue->queue_lock, flags);
we can move this below the initializations.
> +
> + ret = hp_sw_tur(sdev);
> + if (ret != SCSI_DH_OK || h->path_state == HP_SW_PATH_UNINITIALIZED)
> + goto failed;
> +
> + sdev_printk(KERN_INFO, sdev, "%s: %s path\n",
> + HP_SW_NAME, h->path_state == HP_SW_PATH_ACTIVE?
> + "active":"passive");
> +
next prev parent reply other threads:[~2008-05-15 2:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-14 14:43 [PATCH 5/7] scsi_dh: Update hp_sw hardware handler Hannes Reinecke
2008-05-15 2:47 ` Chandra Seetharaman [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-05-20 14:05 Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1210819674.21974.258.camel@chandra-ubuntu \
--to=sekharan@us.ibm.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=hare@suse.de \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox