From: Chandra Seetharaman <sekharan@us.ibm.com>
To: Hannes Reinecke <hare@suse.de>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>,
linux-scsi@vger.kernel.org, dm-devel <dm-devel@redhat.com>
Subject: Re: [PATCH 6/7] scsi_dh: Update RDAC device handler
Date: Fri, 16 May 2008 11:40:23 -0700 [thread overview]
Message-ID: <1210963223.21974.338.camel@chandra-ubuntu> (raw)
In-Reply-To: <482BFC21.8070600@suse.de>
On Thu, 2008-05-15 at 11:02 +0200, Hannes Reinecke wrote:
<snip>
> >> @@ -478,24 +491,9 @@ static int rdac_activate(struct scsi_device *sdev)
> >> struct rdac_dh_data *h = get_rdac_data(sdev);
> >> int err = SCSI_DH_OK;
> >>
> >> - if (h->lun == UNINITIALIZED_LUN) {
> >> - err = get_lun(sdev);
> >> - if (err != SCSI_DH_OK)
> >> - goto done;
> >> - }
> >> -
> >> err = check_ownership(sdev);
> >> - switch (err) {
> >> - case RDAC_UNOWNED:
> >> - break;
> >> - case RDAC_OWNED:
> >> - err = SCSI_DH_OK;
> >> - goto done;
> >> - case RDAC_FAILED:
> >> - default:
> >> - err = SCSI_DH_IO;
> >
> > What does this change yield ? (under check_ownership)
> >
> We're now setting the lun state explicitly, so there's
> no need to return different error codes.
That is my question. what did we gain by the addition of lun_state ?
next prev parent reply other threads:[~2008-05-16 18:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-14 14:43 [PATCH 6/7] scsi_dh: Update RDAC device handler Hannes Reinecke
2008-05-15 2:50 ` Chandra Seetharaman
2008-05-15 9:02 ` Hannes Reinecke
2008-05-16 18:40 ` Chandra Seetharaman [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-05-20 14:05 Hannes Reinecke
2008-05-23 2:08 ` Chandra Seetharaman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1210963223.21974.338.camel@chandra-ubuntu \
--to=sekharan@us.ibm.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=dm-devel@redhat.com \
--cc=hare@suse.de \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).