From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Bottomley Subject: Re: [Re: Linux 2.6.26-rc2] Write protect on on Date: Thu, 22 May 2008 09:23:21 +0100 Message-ID: <1211444601.3956.8.camel@localhost.localdomain> References: <4831A60A.5010308@panasas.com> <4831B2E2.8030700@panasas.com> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: Received: from accolon.hansenpartnership.com ([76.243.235.52]:51071 "EHLO accolon.hansenpartnership.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758916AbYEVXn3 (ORCPT ); Thu, 22 May 2008 19:43:29 -0400 In-Reply-To: Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Linus Torvalds Cc: Boaz Harrosh , Alan Stern , Maciej Rutecki , Linux Kernel Mailing List , USB list , USB Storage list , SCSI development list On Mon, 2008-05-19 at 10:27 -0700, Linus Torvalds wrote: > > On Mon, 19 May 2008, Boaz Harrosh wrote: > > > > Sure, inspecting other places that emulate MODE_SENSE, (And inspecting the scsi > > spec) all zeros is a very good scsi response. Alan do you want to send a fix for all > > places that initiate a MODE_SENSE command, specifically at > > scsi_scan.c::scsi_unlock_floptical() ? (Some other places do) > > I was actualyl more thinking that the safest thing to do would be to just > pre-clear the sense buffer. Then, if some driver doesn't fill it > correctly, big deal.. > > It's not like pre-clearing the bugger is a performance issue. It already is pre cleared, for precisely the reason that some devices lie about returning sense, so we use the zero return to mean no sense was collected. James