From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Gerb Stralko <gerb.stralko@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] scsi: remove CDROM not ready printk
Date: Thu, 29 May 2008 09:55:12 -0500 [thread overview]
Message-ID: <1212072912.3428.28.camel@localhost.localdomain> (raw)
In-Reply-To: <75b57c110805290735i493eca0fp882f4a38901a416c@mail.gmail.com>
On Thu, 2008-05-29 at 10:35 -0400, Gerb Stralko wrote:
> So is that printk really needed? Should the kernel even need to print
> a message like that, esp. if user-space is handling state updates and
> notifications. Or do i need to configure hald to be quietier? FWIW
> I'm using fedora core 9 and hald version:
> -bash-3.2$ /usr/sbin/hald --version
> HAL package version: 0.5.11
Actually, I misspoke; it's set internally via sets of ioctls. However,
it's designed only to show on ioctls that do medium requiring things.
I'm also using FC9 and I see no such messages (and for noisy cgc,
they're printed out for every action on the CD). You have some
application that's poking the CD wrongly (probably not hal), so you
really need to find out what it is. It may be pointing to some other
error in the kernel that needs fixing, but simply removing the message
is covering up the issue.
To help track the application, you could update the printk to print out
current->comm and current->pid. That would tell you who is responsible
James
next prev parent reply other threads:[~2008-05-29 14:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <alpine.LFD.1.10.0805271502370.3985@localhost.localdomain>
2008-05-29 7:41 ` [PATCH] scsi: remove CDROM not ready printk Andrew Morton
2008-05-29 14:05 ` James Bottomley
2008-05-29 14:35 ` Gerb Stralko
2008-05-29 14:51 ` Matthew Wilcox
2008-05-29 14:55 ` James Bottomley [this message]
2008-05-29 15:04 ` Gerb Stralko
2008-05-29 15:22 ` James Bottomley
2008-06-02 0:45 ` Gerb Stralko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1212072912.3428.28.camel@localhost.localdomain \
--to=james.bottomley@hansenpartnership.com \
--cc=akpm@linux-foundation.org \
--cc=gerb.stralko@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).