public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org, Douglas Gilbert <dougg@torque.net>
Subject: Re: [PATCH] scsi_debug: Runtime-configurable sector size
Date: Thu, 05 Jun 2008 10:28:55 -0500	[thread overview]
Message-ID: <1212679735.13549.35.camel@localhost.localdomain> (raw)
In-Reply-To: <yq18wxko6yc.fsf@sermon.lab.mkp.net>

On Thu, 2008-06-05 at 00:12 -0400, Martin K. Petersen wrote:
> Make scsi_debug sector size configurable at load time instead of being
> a #define.  Handy for testing 4KB sectors.
> 
> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

This could have used some checkpatch love:

total: 9 errors, 2 warnings, 181 lines checked

About 8 of the errors are spaces before tab (one is the fact that
checkpatch doesn't like struct * foo, but that's the style of the file,
so I left it in).

James



  parent reply	other threads:[~2008-06-05 15:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-05  4:12 [PATCH] scsi_debug: Runtime-configurable sector size Martin K. Petersen
2008-06-05 12:53 ` Douglas Gilbert
2008-06-05 15:28 ` James Bottomley [this message]
2008-06-06  0:53   ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1212679735.13549.35.camel@localhost.localdomain \
    --to=james.bottomley@hansenpartnership.com \
    --cc=dougg@torque.net \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox