public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Boaz Harrosh <bharrosh@panasas.com>
Cc: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>,
	linux-scsi <linux-scsi@vger.kernel.org>
Subject: Re: [Cbe-oss-dev] [regression/bisected] corrupt CD data after	media change and delay
Date: Tue, 10 Jun 2008 10:56:19 -0500	[thread overview]
Message-ID: <1213113379.3440.23.camel@localhost.localdomain> (raw)
In-Reply-To: <484EA274.2060308@panasas.com>

On Tue, 2008-06-10 at 18:49 +0300, Boaz Harrosh wrote:
> I think, I recall that, any issued command, not only unit_ready, might be appended
> with UNIT_ATTENTION sense. So maybe as a deeper fix (with lots of testing) we want 
> to add this logic into the scsi_check_sense() processing. But I'm not sure either way.

We do .. it's in scsi_io_completion().  The problem is that by design
internally issued commands bypass this, so the problem was that the
internally issued command wasn't doing the correct update.

James



  reply	other threads:[~2008-06-10 15:56 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-06 14:06 [regression/bisected] corrupt CD data after media change and delay Geert Uytterhoeven
2008-06-06 15:13 ` James Bottomley
2008-06-06 17:27   ` Geert Uytterhoeven
2008-06-09 12:54   ` Geert Uytterhoeven
2008-06-09 13:54     ` [Cbe-oss-dev] " Geert Uytterhoeven
2008-06-09 15:05       ` James Bottomley
2008-06-09 15:27         ` Geert Uytterhoeven
     [not found]           ` <1213028647.3508.33.camel@localhost.localdomain>
2008-06-10 15:11             ` Geert Uytterhoeven
2008-06-10 15:22               ` James Bottomley
2008-06-10 15:20           ` James Bottomley
2008-06-10 15:49             ` Boaz Harrosh
2008-06-10 15:56               ` James Bottomley [this message]
2008-06-10 16:12                 ` Boaz Harrosh
2008-06-10 16:17                   ` James Bottomley
2008-06-13 17:33 ` Geert Uytterhoeven
2008-06-18  8:47   ` Alessandro Suardi
2008-06-18 11:13     ` Geert Uytterhoeven
2008-06-18 12:15       ` Alessandro Suardi
2008-06-21 14:18         ` Alessandro Suardi
2008-06-22  8:18           ` Geert Uytterhoeven
2008-06-22 13:14             ` Alessandro Suardi
2008-07-11 21:25               ` Alessandro Suardi
2008-07-12 12:08                 ` Alessandro Suardi
2008-07-13 13:33                   ` James Bottomley
2008-07-23 20:25                     ` Alessandro Suardi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1213113379.3440.23.camel@localhost.localdomain \
    --to=james.bottomley@hansenpartnership.com \
    --cc=Geert.Uytterhoeven@sonycom.com \
    --cc=bharrosh@panasas.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox