Linux SCSI subsystem development
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Matthew Wilcox <matthew@wil.cx>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH 2/4] SCSI multibyte accessors
Date: Mon, 23 Jun 2008 10:32:34 -0500	[thread overview]
Message-ID: <1214235154.3310.1.camel@localhost.localdomain> (raw)
In-Reply-To: <20080623151525.GE4392@parisc-linux.org>

On Mon, 2008-06-23 at 09:15 -0600, Matthew Wilcox wrote:
> Introduce scsi_{get,put}_u{16,24,32}
> 
> The u16 and u32 variants are just aliases for be16 and be32 unaligned
> accessors.  u24 is open-coded byte accessors as the meaning of a
> byteswapped u24 quantity isn't entirely unambiguous, but we know what
> we want to accomplish with scsi_get_u24.
> 
> Also remove scsi_to_u32 and change its only user to scsi_get_u32().

If we're just doing this in the abstract, then we need a u64 as well for
things like port addresses.

Thanks,

James



  reply	other threads:[~2008-06-23 15:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-23 15:15 [PATCH 2/4] SCSI multibyte accessors Matthew Wilcox
2008-06-23 15:32 ` James Bottomley [this message]
2008-06-23 15:54   ` Matthew Wilcox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1214235154.3310.1.camel@localhost.localdomain \
    --to=james.bottomley@hansenpartnership.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=matthew@wil.cx \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox