From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: David Miller <davem@davemloft.net>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH] esp: tidy up target reference counting
Date: Tue, 24 Jun 2008 11:28:04 -0500 [thread overview]
Message-ID: <1214324884.3299.63.camel@localhost.localdomain> (raw)
In-Reply-To: <20080623.145828.60746793.davem@davemloft.net>
On Mon, 2008-06-23 at 14:58 -0700, David Miller wrote:
> From: James Bottomley <James.Bottomley@HansenPartnership.com>
> Date: Mon, 23 Jun 2008 14:52:09 -0500
>
> > The esp driver currently does hand rolled reference counting of its
> > target. It's much easier to do what it needs to do if it's plugged into
> > the mid-layer callbacks (target_alloc and target_destroy) which were
> > designed for this case, so do it this way and get rid of the internal
> > target reference count.
> >
> > Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
>
> Much cleaner, thanks!
>
> Signed-off-by: David S. Miller <davem@davemloft.net>
You're welcome ... I actually initially queued this for the merge
window, but since this looks like it fixes a bug that would affect any
multi-lun installation, isn't it a candidate for the current git head
(and indeed for stable), or isn't there that much of a multi-lun install
base with this driver to worry about?
James
next prev parent reply other threads:[~2008-06-24 16:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-23 19:52 [PATCH] esp: tidy up target reference counting James Bottomley
2008-06-23 21:58 ` David Miller
2008-06-24 16:28 ` James Bottomley [this message]
2008-06-24 20:36 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1214324884.3299.63.camel@localhost.localdomain \
--to=james.bottomley@hansenpartnership.com \
--cc=davem@davemloft.net \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox