From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chandra Seetharaman Subject: Re: [PATCH 1/9] scsi_dh: Implement common device table handling Date: Thu, 26 Jun 2008 07:41:03 -0700 Message-ID: <1214491263.31845.0.camel@chandra-ubuntu> References: <20080624100349.06F5A10B5DE@craiglockhart-ipmi.suse.de> <1214441566.32521.10.camel@chandra-ubuntu> <48638F7C.9090602@suse.de> Reply-To: sekharan@us.ibm.com Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: Received: from e2.ny.us.ibm.com ([32.97.182.142]:52558 "EHLO e2.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752638AbYFZOlK (ORCPT ); Thu, 26 Jun 2008 10:41:10 -0400 Received: from d01relay02.pok.ibm.com (d01relay02.pok.ibm.com [9.56.227.234]) by e2.ny.us.ibm.com (8.13.8/8.13.8) with ESMTP id m5QEf7BA024389 for ; Thu, 26 Jun 2008 10:41:07 -0400 Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216]) by d01relay02.pok.ibm.com (8.13.8/8.13.8/NCO v9.0) with ESMTP id m5QEf74r215758 for ; Thu, 26 Jun 2008 10:41:07 -0400 Received: from d01av02.pok.ibm.com (loopback [127.0.0.1]) by d01av02.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m5QEf6qf012513 for ; Thu, 26 Jun 2008 10:41:07 -0400 In-Reply-To: <48638F7C.9090602@suse.de> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Hannes Reinecke Cc: James Bottomley , dm-devel@redhat.com, linux-scsi@vger.kernel.org Great then. Acked-by: Chandra Seetharaman On Thu, 2008-06-26 at 14:45 +0200, Hannes Reinecke wrote: > Hi Chandra, > > Chandra Seetharaman wrote: > > Other than one minor issue the code looks good (sorry for the late > > realization on my part). > > > > Issue: scsi_dh_handler_detach() references scsi_dh with no check for > > null and scsi_dh_notifier() call it with scsi_dh == NULL. code can be > > changed to get the device handler from sdev. > > > This is fixed in patch 7/9. I thought I had rediffed them properly, > but apparently not. Sorry for that. > > Thanks for the review. > > Cheers, > > Hannes