From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Elias Oltmanns <eo@nebensachen.de>
Cc: linux-scsi@vger.kernel.org, stable@kernel.org
Subject: Re: [PATCH] SCSI: Fix some locking issues
Date: Tue, 01 Jul 2008 20:55:00 -0500 [thread overview]
Message-ID: <1214963700.3316.41.camel@localhost.localdomain> (raw)
In-Reply-To: <87prpxnv4w.fsf@denkblock.local>
On Tue, 2008-07-01 at 23:37 +0200, Elias Oltmanns wrote:
> Hi James,
>
> sorry for bothering you but I've just noticed that the patch below has
> neither been scheduled for the stable review, nor queued up for Linus.
> May be you just don't consider this serious enough for these trees but I
> wanted to make sure that the situation will be dealt with eventualy. The
> patch applies to 2.6.26-rc8.
OK, well at first glance, the locking around device_blocked and
host_blocked looks pointless. What are the failure traces you're using
to decide they need spinlock protection?
The blk_plug_queue change looks reasonable ... however, blk_plug_queue
itself looks like it might not entirely need the queue lock ... I need
to investigate more closely.
James
next prev parent reply other threads:[~2008-07-02 1:55 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-29 11:38 [PATCH] SCSI: Fix some locking issues Elias Oltmanns
2008-07-01 21:37 ` Elias Oltmanns
2008-07-02 1:55 ` James Bottomley [this message]
2008-07-02 7:08 ` Elias Oltmanns
2008-07-02 11:50 ` Jens Axboe
2008-07-02 14:49 ` James Bottomley
2008-07-02 18:45 ` Jens Axboe
2008-07-02 20:18 ` James Bottomley
2008-07-03 7:53 ` Elias Oltmanns
2008-07-03 10:38 ` Elias Oltmanns
2008-07-03 11:24 ` Jens Axboe
2008-07-03 16:31 ` James Bottomley
2008-07-03 17:54 ` Jens Axboe
2008-07-03 19:47 ` Elias Oltmanns
2008-07-03 21:33 ` James Bottomley
2008-07-02 14:46 ` James Bottomley
2008-07-02 15:59 ` Elias Oltmanns
2008-07-02 16:23 ` Matthew Wilcox
2008-07-03 7:12 ` Elias Oltmanns
2008-07-03 15:22 ` James Bottomley
2008-07-03 19:39 ` Elias Oltmanns
2008-07-03 15:47 ` Matthew Wilcox
2008-07-02 16:32 ` James Bottomley
2008-07-03 7:25 ` Elias Oltmanns
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1214963700.3316.41.camel@localhost.localdomain \
--to=james.bottomley@hansenpartnership.com \
--cc=eo@nebensachen.de \
--cc=linux-scsi@vger.kernel.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox