From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Hannes Reinecke <hare@suse.de>
Cc: SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH 0/2] scsi_dh patchset fixes
Date: Fri, 04 Jul 2008 10:05:59 -0500 [thread overview]
Message-ID: <1215183959.5413.10.camel@localhost.localdomain> (raw)
In-Reply-To: <486E2986.6090209@suse.de>
On Fri, 2008-07-04 at 15:45 +0200, Hannes Reinecke wrote:
> Hi James,
>
> these patches just fix the suggestions made by you and Mike C.
> - Check the return code from try_module_get()
> - Use GFP_ATOMIC in the IO path
I thought the final agreement was that these should be GFP_NOIO?
> Patches apply on top of my previous patchset for the scsi_dh fixes.
Could you not do this? The GFP_KERNEL will spit might sleep warnings on
certain configs and the try_module_get could cause an oops on removal.
Either of these might confuse a bisection search if it accidentally
landed in them. In general, for unapplied patches with identified bugs,
the patches should be fixed before applying.
Thanks,
James
next prev parent reply other threads:[~2008-07-04 15:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-04 13:45 [PATCH 0/2] scsi_dh patchset fixes Hannes Reinecke
2008-07-04 15:05 ` James Bottomley [this message]
2008-07-09 7:17 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1215183959.5413.10.camel@localhost.localdomain \
--to=james.bottomley@hansenpartnership.com \
--cc=hare@suse.de \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox