From: David Woodhouse <dwmw2@infradead.org>
To: Matthew Wilcox <matthew@wil.cx>
Cc: Jaswinder Singh <jaswinder@infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
kernel-janitors <kernel-janitors@vger.kernel.org>,
kernelnewbies <kernelnewbies@nl.linux.org>,
linux-scsi@vger.kernel.org, hch@infradead.org
Subject: Re: [PATCH] advansys: use request_firmware
Date: Mon, 14 Jul 2008 07:56:44 -0700 [thread overview]
Message-ID: <1216047404.27455.31.camel@shinybook.infradead.org> (raw)
In-Reply-To: <20080714145033.GD14894@parisc-linux.org>
On Mon, 2008-07-14 at 08:50 -0600, Matthew Wilcox wrote:
> I'm not quite sure whether my question was answered ...
>
> When firmware is built in, does
> 1) request_firmware() make a copy of it and then release_firmware free
> that copy?
> 2) request_firmware() return a pointer to the built-in firmware with
> release_firmware() being a no-op?
> 3) request_firmware() return a pointer to the built-in firmware with
> release_firmware() freeing the original?
>
> Cases 1 and 2 are fine, case 3 is a problem.
Effectively (2).
Actually we do allocate and free the 'struct firmware' but fw->data is
just pointed to the original blob, and then that blob doesn't get freed.
--
dwmw2
next prev parent reply other threads:[~2008-07-14 14:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-11 9:58 [PATCH] advansys: use request_firmware Jaswinder Singh
2008-07-12 16:29 ` Matthew Wilcox
2008-07-12 17:09 ` Jaswinder Singh
2008-07-14 14:50 ` Matthew Wilcox
2008-07-14 14:56 ` David Woodhouse [this message]
2008-07-14 15:15 ` Matthew Wilcox
2008-07-14 15:22 ` David Woodhouse
-- strict thread matches above, loose matches on Subject: below --
2008-12-20 15:25 Jaswinder Singh
2008-12-20 15:32 ` Matthew Wilcox
2008-12-20 16:02 ` Jaswinder Singh
2009-01-10 15:20 David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1216047404.27455.31.camel@shinybook.infradead.org \
--to=dwmw2@infradead.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=hch@infradead.org \
--cc=jaswinder@infradead.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=kernelnewbies@nl.linux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox