* [PATCH] 2.4.21-pre3 scsi_scan.c memory leak.
@ 2003-01-17 18:58 Justin T. Gibbs
0 siblings, 0 replies; only message in thread
From: Justin T. Gibbs @ 2003-01-17 18:58 UTC (permalink / raw)
To: Linux Scsi Mailing List
I found this while doing a longevity load/unload test of the aic79xx
driver. I can't say if this is the only memory leak in the unload
process, but its at least one of them. This only cleans up properly
in the common cases of failure in scan_scsis_single(). The whole
routines a bit of a mess....
--
Justin
--- scsi_scan.c 2003-01-17 11:53:07.000000000 -0700
+++ scsi_scan.c.mine 2003-01-17 11:53:03.000000000 -0700
@@ -596,6 +596,7 @@
} else {
/* assume no peripheral if any other sort of error */
scsi_release_request(SRpnt);
+ scsi_release_commandblocks(SDpnt);
return 0;
}
}
@@ -619,6 +620,7 @@
*/
if ((scsi_result[0] >> 5) == 3) {
scsi_release_request(SRpnt);
+ scsi_release_commandblocks(SDpnt);
return 0; /* assume no peripheral if any sort of error */
}
/* The Toshiba ROM was "gender-changed" here as an inline hack.
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2003-01-17 18:58 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-01-17 18:58 [PATCH] 2.4.21-pre3 scsi_scan.c memory leak Justin T. Gibbs
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox