From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Mike Christie <michaelc@cs.wisc.edu>
Cc: Hannes Reinecke <hare@suse.de>, linux-scsi@vger.kernel.org
Subject: Re: [PATCH 4/8] scsi_dh: Update hp_sw hardware handler
Date: Thu, 17 Jul 2008 18:50:05 -0500 [thread overview]
Message-ID: <1216338605.5515.105.camel@localhost.localdomain> (raw)
In-Reply-To: <487FD600.1060000@cs.wisc.edu>
On Thu, 2008-07-17 at 18:30 -0500, Mike Christie wrote:
> Hannes Reinecke wrote:
> > case NOT_READY:
> > - if ((sshdr.asc == 0x04) && (sshdr.ascq == 3)) {
> > - rc = SCSI_DH_RETRY;
> > - h->retries++;
> > + if ((sshdr.asc == 0x04) && (sshdr.ascq == 2)) {
>
> I forgot what we decided. Was this supposed to be 2 or 3? If it was 2,
> then patch looks ok.
>
> Acked-by: Mike Christie <michaelc@cs.wisc.edu>
Yes, for HP storage it's 2 ... that's initialising command required.
James
next prev parent reply other threads:[~2008-07-17 23:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-17 7:38 [PATCH 4/8] scsi_dh: Update hp_sw hardware handler Hannes Reinecke
2008-07-17 23:30 ` Mike Christie
2008-07-17 23:50 ` James Bottomley [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-07-17 23:52 [PATCH 0/8] scsi_dh update Chandra Seetharaman
2008-07-17 23:53 ` [PATCH 4/8] scsi_dh: Update hp_sw hardware handler Chandra Seetharaman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1216338605.5515.105.camel@localhost.localdomain \
--to=james.bottomley@hansenpartnership.com \
--cc=hare@suse.de \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox