From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: akpm@linux-foundation.org, linux-scsi@vger.kernel.org,
stefanr@s5r6.in-berlin.de
Subject: Re: [patch 17/18] scsi: select CRC_T10DIF only when necessary
Date: Thu, 21 Aug 2008 10:07:05 -0500 [thread overview]
Message-ID: <1219331225.3265.22.camel@localhost.localdomain> (raw)
In-Reply-To: <yq1ljyqfmnu.fsf@sermon.lab.mkp.net>
On Thu, 2008-08-21 at 10:49 -0400, Martin K. Petersen wrote:
> >>>>> "James" == James Bottomley <James.Bottomley@HansenPartnership.com> writes:
>
> James> Actually, I don't think this is right at all.
>
> James> This is a purely cosmetic fix and the tip of the iceberg. If
> James> not compiling in the integrity code matters on grounds of
> James> kernel bloat, and I think it does, then the correct fix is to
> James> make sure none of it compiles into SD if BLK_DEV_INTEGRITY
> James> isn't set.
>
> The only code that currently uses the T10 CRC is in sd_dif.c. And
> that file isn't compiled in if BLK_DEV_INTEGRITY isn't set.
Oh, OK ... I missed that bit, Thanks!
James
prev parent reply other threads:[~2008-08-21 15:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-20 23:55 [patch 17/18] scsi: select CRC_T10DIF only when necessary akpm
2008-08-21 14:01 ` Martin K. Petersen
2008-08-21 14:19 ` James Bottomley
2008-08-21 14:49 ` Martin K. Petersen
2008-08-21 15:07 ` James Bottomley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1219331225.3265.22.camel@localhost.localdomain \
--to=james.bottomley@hansenpartnership.com \
--cc=akpm@linux-foundation.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox