From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Bottomley Subject: Re: [PATCH] scsi/sd: Fix size output in MB Date: Sat, 30 Aug 2008 16:45:49 -0500 Message-ID: <1220132749.3615.14.camel@localhost.localdomain> References: <48B9546B.4010004@simon.arlott.org.uk> <1220117091.3615.3.camel@localhost.localdomain> <20080830174516.GD1239@parisc-linux.org> <20080830225950.4828dcf6@mjolnir.drzeus.cx> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: Received: from accolon.hansenpartnership.com ([76.243.235.52]:48573 "EHLO accolon.hansenpartnership.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754555AbYH3Vpt (ORCPT ); Sat, 30 Aug 2008 17:45:49 -0400 In-Reply-To: <20080830225950.4828dcf6@mjolnir.drzeus.cx> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Pierre Ossman Cc: Matthew Wilcox , Simon Arlott , Linux Kernel Mailing List , linux-scsi On Sat, 2008-08-30 at 22:59 +0200, Pierre Ossman wrote: > On Sat, 30 Aug 2008 11:45:16 -0600 > Matthew Wilcox wrote: > > > > > 2. We should report in GB or TB when appropriate. The exact definition > > of 'appropriate' is going to vary from person to person. Might I > > suggest that we should report between two and four significant digits. > > eg 9543 MB is ok, 10543 MB should be 10 GB. > > > > I've been looking at doing something like this for the mmc_block > driver, so a generic helper is welcome. :) Does MMC have the 10^3 requirement like SCSI/ATA disks do, or can you use 2^10 like standard computer stuff for capacities? James