From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Greg KH <greg@kroah.com>
Cc: Jing Huang <huangj@Brocade.COM>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
Ramkumar Vadivelu <rvadivel@Brocade.COM>,
Vinodh Ravindran <vravindr@Brocade.COM>,
"Srikanth Rayas (CW)" <srayas@Brocade.COM>
Subject: Re: [PATCH 1/6] bfa: Brocade BFA FC SCSI Driver submission
Date: Wed, 24 Sep 2008 22:14:04 -0700 [thread overview]
Message-ID: <1222319644.3602.1.camel@localhost.localdomain> (raw)
In-Reply-To: <20080925044923.GA4310@kroah.com>
On Wed, 2008-09-24 at 21:49 -0700, Greg KH wrote:
> On Wed, Sep 24, 2008 at 08:56:14PM -0700, Jing Huang wrote:
> > --- orig/drivers/scsi/bfa/bfad_attr.c 1969-12-31 16:00:00.000000000
> > -0800
> > +++ patch/drivers/scsi/bfa/bfad_attr.c 2008-09-24 12:08:23.000000000
> > -0700
> > @@ -0,0 +1,660 @@
> > +/*
> > + * Copyright (c) 2005-2008 Brocade Communications Systems, Inc.
> > + * All rights reserved
> > + * www.brocade.com
> > + *
> > + * Linux driver for Brocade Fibre Channel Host Bus Adapter.
> > + *
> > + * This program is free software; you can redistribute it and/or modify
> > it
>
> Your patch is line-wrapped and can't be applied :(
Actually, it's more than just linewrapping. The patch to the Makefile
looks to be actively mangled:
+++ patch/drivers/scsi/bfa/Makefile 2008-09-24 12:08:24.000000000
-0700
@@ -0,0 +1,25 @@
+#
+# Copyright (c) 2005-2008 Brocade Communications Systems, Inc.
+# All rights reserved
+# www.brocade.com
+#
+# Linux driver for Brocade Fibre Channel Host Bus Adapter.
+#
+# This program is free software; you can redistribute it and/or modify
+it # under the terms of the GNU General Public License (GPL) Version 2
+as # published by the Free Software Foundation # # This program is
+distributed in the hope that it will be useful, but # WITHOUT ANY
+WARRANTY; without even the implied warranty of # MERCHANTABILITY or
+FITNESS FOR A PARTICULAR PURPOSE. See the GNU # General Public License
The # beginning the line got wrapped here before the patch was made.
James
next prev parent reply other threads:[~2008-09-25 5:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-25 3:56 [PATCH 1/6] bfa: Brocade BFA FC SCSI Driver submission Jing Huang
2008-09-25 4:49 ` Greg KH
2008-09-25 5:14 ` James Bottomley [this message]
2008-09-25 5:33 ` Jing Huang
2008-09-25 5:41 ` James Bottomley
[not found] ` <20080925055725.GC66712@sgi.com>
2008-09-25 6:09 ` Jing Huang
2008-09-25 15:34 ` James Bottomley
2008-09-25 16:56 ` Jing Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1222319644.3602.1.camel@localhost.localdomain \
--to=james.bottomley@hansenpartnership.com \
--cc=greg@kroah.com \
--cc=huangj@Brocade.COM \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=rvadivel@Brocade.COM \
--cc=srayas@Brocade.COM \
--cc=vravindr@Brocade.COM \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox