From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
Kai Makisara <Kai.Makisara@kolumbus.fi>
Subject: Re: [PATCH git latest] drivers/scsi: fixing wrong comment before new_buffer_tape()
Date: Fri, 26 Sep 2008 09:20:56 -0700 [thread overview]
Message-ID: <1222446056.3971.19.camel@localhost.localdomain> (raw)
In-Reply-To: <20080926170937.2983fc29@lxorguk.ukuu.org.uk>
On Fri, 2008-09-26 at 17:09 +0100, Alan Cox wrote:
> > > Looks true to me for the current versions of the code. In fact it is only
> > > ever called from the initialisation function that I can see so chunks of
> > > the code could simply go away as well as bits of the comment. Ditto the
> > > one in drivers/scsi/st.c
> > >
> > > Acked-by: Alan Cox <alan@redhat.com>
> > >
> >
> > I am sorry I didn't quite understand. You mean it is true that caller
> > must hold os_scsi_tapes_lock?
>
> Sorry - I mean what you claim is true - that the comment is incorrect.
So, I think I'm missing a piece of this: There's no patch in this
thread (I presume it's lurking somewhere on lkml). Could someone repost
the proposed patch and copy the tape maintainer: Kai Makisara
<Kai.Makisara@kolumbus.fi> to get his input?
Thanks,
James
next prev parent reply other threads:[~2008-09-26 16:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080925174948.GA14180@carmen.cs.uiuc.edu>
2008-09-26 10:13 ` [PATCH git latest] drivers/scsi: fixing wrong comment before new_buffer_tape() Alan Cox
2008-09-26 16:05 ` Tammy
2008-09-26 16:09 ` Alan Cox
2008-09-26 16:20 ` James Bottomley [this message]
2008-09-26 17:06 ` Lin Tan
2008-09-26 19:55 ` Kai Makisara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1222446056.3971.19.camel@localhost.localdomain \
--to=james.bottomley@hansenpartnership.com \
--cc=Kai.Makisara@kolumbus.fi \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox