public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Jens Axboe <jens.axboe@oracle.com>
Cc: David Miller <davem@davemloft.net>,
	mroos@ut.ee, bharrosh@panasas.com, matthew@wil.cx,
	linux-scsi@vger.kernel.org, sparclinux@vger.kernel.org
Subject: Re: qlogicpti driver hangs the machine
Date: Mon, 29 Sep 2008 09:04:31 -0500	[thread overview]
Message-ID: <1222697071.3150.0.camel@localhost.localdomain> (raw)
In-Reply-To: <20080929063355.GK2677@kernel.dk>

On Mon, 2008-09-29 at 08:33 +0200, Jens Axboe wrote:
> On Sun, Sep 28 2008, David Miller wrote:
> > From: Meelis Roos <mroos@ut.ee>
> > Date: Wed, 24 Sep 2008 12:51:09 +0300 (EEST)
> > 
> > > > Subject: [PATCH] fix fall out of sg-chaining patch
> > > > 
> > > > I've reviewed all patches since Matthew's, and I find one small
> > > > problem.
> > > > 
> > > > In the load_cmd() there is a compound loop where the first 4 sg's are
> > > > set then the rest are set into a memory structure in group of 7 sg's.
> > > > 
> > > > Well the second 7-group and on is a bug because sg pointer does not advance.
> > > > This is a fall out from Jens's patch.
> > > > 
> > > > I'm not sure if this is it but it should be fixed
> > > 
> > > This definitely helps,
> > 
> > Can we get this bug fix merged if it isn't already?
> 
> I'll take care of it.

Actually, I already have it in rc fixes which are due out this morning.

James



  reply	other threads:[~2008-09-29 14:04 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-23 15:06 qlogicpti driver hangs the machine Meelis Roos
2008-09-23 15:59 ` Matthew Wilcox
2008-09-23 21:50   ` Meelis Roos
2008-09-24  4:25   ` David Miller
2008-09-24  4:42     ` Matthew Wilcox
2008-09-24  4:53       ` David Miller
2008-09-24  8:45         ` David Miller
2008-09-24  9:00           ` Boaz Harrosh
2008-09-24  9:03             ` David Miller
2008-09-24  9:21               ` Meelis Roos
2008-09-24  9:51             ` Meelis Roos
2008-09-28 20:43               ` David Miller
2008-09-29  6:33                 ` Jens Axboe
2008-09-29 14:04                   ` James Bottomley [this message]
2008-09-24  9:21           ` Meelis Roos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1222697071.3150.0.camel@localhost.localdomain \
    --to=james.bottomley@hansenpartnership.com \
    --cc=bharrosh@panasas.com \
    --cc=davem@davemloft.net \
    --cc=jens.axboe@oracle.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=matthew@wil.cx \
    --cc=mroos@ut.ee \
    --cc=sparclinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox