public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: device-mapper development <dm-devel@redhat.com>
Cc: sekharan@us.ibm.com, linux-scsi@vger.kernel.org, agk@redhat.com,
	jens.axboe@oracle.com
Subject: Re: [dm-devel] Re: [BUG] dm-mpath and scsi persistent reservation
Date: Wed, 22 Oct 2008 14:30:16 -0600	[thread overview]
Message-ID: <1224707416.6851.33.camel@localhost.localdomain> (raw)
In-Reply-To: <20081022215402.214a4ef8@plop>

On Wed, 2008-10-22 at 21:54 +0200, Christophe Varoqui wrote:
> It seems to me the device handler infrastructure proposes to translate
> scsi error codes from requests generated by the device handler itself. I
> don't know how we can detect a reservation conflict from a device
> handler without submitting a dangerous write io.

For SCSI-2 reservations, Test Unit Ready will do this for you.

For SCSI-3, you're right, it's more complex.  You actually have to use
the PR IN commands to read the reservations if you don't want to test
what they'll actually do with an I/O.

> I don't see how we could use a device handler to translate an scsi error
> code from a write io submitted to the multipath device map. Do you ?

Well, there is a problem.  Reservation Conflict should be treated as a
device error and passed straight up ... it shouldn't really have any
effect on dm mp because a path switch is unlikely to fix any issues.  So
dm mp shouldn't be intercepting this type of error at all.

James



  reply	other threads:[~2008-10-22 20:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-21 21:19 [BUG] dm-mpath and scsi persistent reservation Christophe Varoqui
2008-10-21 22:48 ` Chandra Seetharaman
2008-10-22 19:54   ` Christophe Varoqui
2008-10-22 20:30     ` James Bottomley [this message]
2008-10-23  2:53       ` [dm-devel] " Mike Christie
2008-10-22 21:21     ` Chandra Seetharaman
2008-10-23 19:30       ` Christophe Varoqui
2008-10-23 21:03   ` Christophe Varoqui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1224707416.6851.33.camel@localhost.localdomain \
    --to=james.bottomley@hansenpartnership.com \
    --cc=agk@redhat.com \
    --cc=dm-devel@redhat.com \
    --cc=jens.axboe@oracle.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=sekharan@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox