From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: "Örjan Nordlund" <orjan.nordlund@gmail.com>,
"SCSI development list" <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] SCSI: detect missing data for INQUIRY
Date: Mon, 27 Oct 2008 12:29:33 -0500 [thread overview]
Message-ID: <1225128573.5146.34.camel@localhost.localdomain> (raw)
In-Reply-To: <Pine.LNX.4.44L0.0810271325470.2296-100000@iolanthe.rowland.org>
On Mon, 2008-10-27 at 13:27 -0400, Alan Stern wrote:
> On Mon, 27 Oct 2008, James Bottomley wrote:
>
> > > > About the best we can do is check the first four fields. For them to be
> > > > all zero, it would have to be a minimal response SCSI-1 device (RDF of
> > > > zero) ... hopefully they're all dead by now.
> > >
> > > Then you're saying that the patch should everything up to
> > > inq_result[8]? Or maybe even beyond? I can do that. Would that be
> > > acceptable?
> >
> > No ... "first four fields" means everything up to inq_result[3].
> > Anything beyond that would be legitimately zero if they were.
>
> But what about the case where the first four bytes are zero and some of
> the fields beyond them are nonzero. Isn't that possible?
Not if the device conforms to the standard.
James
next prev parent reply other threads:[~2008-10-27 17:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-27 16:18 [PATCH] SCSI: detect missing data for INQUIRY Alan Stern
2008-10-27 16:37 ` James Bottomley
2008-10-27 17:00 ` Alan Stern
2008-10-27 17:08 ` James Bottomley
2008-10-27 17:27 ` Alan Stern
2008-10-27 17:29 ` James Bottomley [this message]
2008-10-27 18:53 ` [PATCH v2] " Alan Stern
2008-10-28 13:02 ` James Smart
2008-10-28 13:43 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1225128573.5146.34.camel@localhost.localdomain \
--to=james.bottomley@hansenpartnership.com \
--cc=linux-scsi@vger.kernel.org \
--cc=orjan.nordlund@gmail.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox