public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Cc: bharrosh@panasas.com, seokmann.ju@qlogic.com,
	James.Smart@Emulex.Com, linux-scsi@vger.kernel.org,
	andrew.vasquez@qlogic.com, michaelc@cs.wisc.edu,
	robert.w.love@intel.com
Subject: Re: [PATCH 1/2] scsi_transport_fc: FC pass through support - revised II
Date: Thu, 30 Oct 2008 08:39:34 -0500	[thread overview]
Message-ID: <1225373974.3250.0.camel@localhost.localdomain> (raw)
In-Reply-To: <20081030172537K.fujita.tomonori@lab.ntt.co.jp>

On Thu, 2008-10-30 at 17:29 +0900, FUJITA Tomonori wrote:
> On Thu, 30 Oct 2008 09:51:40 +0200
> Boaz Harrosh <bharrosh@panasas.com> wrote:
> 
> > Do you know what is the difference between "req->error =" and the error
> > passed to blk_end_xxx_request(req, error, ...) ?
> 
> I guess that blk_end_xxx_request(req, error, ...) is common Linux
> error code, -EIO, etc. req->error carries protocol specific errors;
> SAM_STAT_*, DID_*, etc in the case of SCSI. But I'm not confident.

Yes, that's it precisely.  The blk_end_request() carries a translated
UNIX error code for the user (usually -EIO).  req->error carries the
transport error in its full glory (although it may lack pieces that
won't fit into 32 bits).

James



  reply	other threads:[~2008-10-30 13:39 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-29 12:48 [PATCH 1/2] scsi_transport_fc: FC pass through support - revised II Seokmann Ju
2008-10-29 13:12 ` Boaz Harrosh
2008-10-30  4:18 ` FUJITA Tomonori
2008-10-30  7:51   ` Boaz Harrosh
2008-10-30  8:29     ` FUJITA Tomonori
2008-10-30 13:39       ` James Bottomley [this message]
2008-10-30 13:37   ` Seokmann Ju
2008-10-30 14:12     ` Boaz Harrosh
2008-10-30 14:47       ` Seokmann Ju
2008-10-30 23:12     ` FUJITA Tomonori
2008-10-31  1:38     ` Seokmann Ju
2008-10-31  1:57       ` FUJITA Tomonori
2008-10-31  2:57         ` Seokmann Ju

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1225373974.3250.0.camel@localhost.localdomain \
    --to=james.bottomley@hansenpartnership.com \
    --cc=James.Smart@Emulex.Com \
    --cc=andrew.vasquez@qlogic.com \
    --cc=bharrosh@panasas.com \
    --cc=fujita.tomonori@lab.ntt.co.jp \
    --cc=linux-scsi@vger.kernel.org \
    --cc=michaelc@cs.wisc.edu \
    --cc=robert.w.love@intel.com \
    --cc=seokmann.ju@qlogic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox