From: Miquel van Smoorenburg <mikevs@xs4all.net>
To: Boaz Harrosh <bharrosh@panasas.com>
Cc: linux-scsi@vger.kernel.org,
James Bottomley <James.Bottomley@HansenPartnership.com>
Subject: Re: 2.6.27 and good_bytes -= scsi_get_resid(cmd)
Date: Wed, 05 Nov 2008 00:04:50 +0100 [thread overview]
Message-ID: <1225839890.15241.5.camel@localhost.localdomain> (raw)
In-Reply-To: <491008B2.5030605@panasas.com>
On Tue, 2008-11-04 at 10:32 +0200, Boaz Harrosh wrote:
> Miquel van Smoorenburg wrote:
> > I upgraded to 2.6.27 on a machine with the dpt_i2o scsi driver and
> > I'm seeing some weird number from iostat -x 2. Basically it thinks
> > that the size of every request is 32640 sectors (0xff0000 bytes),
> > and that throws off the stats considerably.
[... dpt_i2o.c patch ...]
> Why does the readl(reply+5) does not return the same number as
> scsi_bufflen(cmd). This is the real problem.
You're right, ofcourse. Thanks. I had a good look over the code and
reply+5 is wrong. It should be reply + 5*sizeof(u32). In the same
function all other values read from an offset which is a multiple of 4,
which I should have noticed earlier I guess.
I'll send a new patch in a seperate mail.
Mike.
prev parent reply other threads:[~2008-11-04 23:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-03 21:50 2.6.27 and good_bytes -= scsi_get_resid(cmd) Miquel van Smoorenburg
2008-11-04 8:32 ` Boaz Harrosh
2008-11-04 23:04 ` Miquel van Smoorenburg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1225839890.15241.5.camel@localhost.localdomain \
--to=mikevs@xs4all.net \
--cc=James.Bottomley@HansenPartnership.com \
--cc=bharrosh@panasas.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox