From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Bottomley Subject: Re: [PATCH 03/18] libosd: OSDv1 Headers Date: Wed, 05 Nov 2008 08:09:32 -0500 Message-ID: <1225890572.4703.15.camel@localhost.localdomain> References: <491073BB.4000900@panasas.com> <1225817046-5946-1-git-send-email-bharrosh@panasas.com> <20081104111037.bcae04e5.akpm@linux-foundation.org> <49119774.10706@panasas.com> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: Received: from accolon.hansenpartnership.com ([76.243.235.52]:33209 "EHLO accolon.hansenpartnership.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755068AbYKENJq (ORCPT ); Wed, 5 Nov 2008 08:09:46 -0500 In-Reply-To: <49119774.10706@panasas.com> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Boaz Harrosh Cc: Andrew Morton , michaelc@cs.wisc.edu, fujita.tomonori@lab.ntt.co.jp, jeff@garzik.org, osd-dev@open-osd.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Sami.Iren@seagate.com, pw@padd.com On Wed, 2008-11-05 at 14:54 +0200, Boaz Harrosh wrote: > >> + struct _osd_io_info { > >> + struct bio *bio; > >> + u64 total_bytes; > > > > u64(!) > > > > Do you mean that I need to use __u64? or what do you mean? He means you've used u64 in a header without actually including any file that defines the typedef. Linux header files aren't supposed to depend on include order. They're supposed to stand alone. The point is that if I include just #include osd_initiator.h into an empty kernel file it's not supposed to spit undefined errors. Right at the moment the u64 probably works because blkdev.h #includes the file which defines it, but you're not supposed to rely on that. James