From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Bernd Schubert <bs@q-leap.de>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH 2/7] Allow requeuement on DID_SOFT_ERROR
Date: Wed, 26 Nov 2008 12:47:47 -0600 [thread overview]
Message-ID: <1227725267.3387.20.camel@localhost.localdomain> (raw)
In-Reply-To: <200811261846.51644.bs@q-leap.de>
On Wed, 2008-11-26 at 18:46 +0100, Bernd Schubert wrote:
> Activate the error handler if DID_SOFT_ERROR failed to often, but only
> for commands which have a scmd->allowed > 1.
> Also make a function out of a goto-block.
What is the rationale for this? It really doesn't look right since
DID_SOFT_ERROR is supposed to be for temporary out of resource
conditions in the HBA driver ... activating the error handler isn't
really going to fix this because the eh is taking us through a state
model for device conditions, which DID_SOFT_ERROR shouldn't be.
If you just need a DID_FAIL to activate the eh, it can be added without
changing the meaning of DID_SOFT_ERROR.
Also, you changed the return to make it device blocking (which also
doesn't look right) but didn't document that in the change log.
James
next prev parent reply other threads:[~2008-11-26 18:47 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-26 17:40 [PATCH 0/7] scsi error handler improvements Bernd Schubert
2008-11-26 17:44 ` [PATCH 1/7] print eh activation Bernd Schubert
2008-11-26 18:47 ` James Bottomley
2008-12-03 11:19 ` Bernd Schubert
2008-12-03 15:16 ` James Bottomley
2008-12-03 15:52 ` Bernd Schubert
2008-11-26 17:46 ` [PATCH 2/7] Allow requeuement on DID_SOFT_ERROR Bernd Schubert
2008-11-26 18:47 ` James Bottomley [this message]
2008-12-03 12:17 ` Bernd Schubert
2008-12-03 15:16 ` James Bottomley
2008-12-03 16:00 ` Bernd Schubert
2008-12-03 16:29 ` James Bottomley
2008-12-03 17:06 ` Bernd Schubert
2008-11-26 18:25 ` [PATCH 03/07] Don't online offlined devices in scsi_target_quiesce() Bernd Schubert
2008-11-26 18:26 ` [PATCH 4/7] allow activation of eh on DID_NO_CONNECT Bernd Schubert
2008-11-26 18:29 ` [PATCH 5/7] time needs to be adjusted when eh was running Bernd Schubert
2009-01-07 18:09 ` Bernd Schubert
2008-11-26 18:31 ` [PATCH 6/7] SYNCHRONIZE_CACHE command used fixed value Bernd Schubert
2008-11-26 18:32 ` [PATCH 0/7] trivial: move a variable from function to if-scope Bernd Schubert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1227725267.3387.20.camel@localhost.localdomain \
--to=james.bottomley@hansenpartnership.com \
--cc=bs@q-leap.de \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox